[THRIFT-4883] Thrift 0.12.0 source lua lib has a mistake

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 0.12.0
• Component/s: Lua - Library
• Labels: easyfix
• Assignee: Unassigned
• Reporter: Nguyen Duc Duy
• Created: 07/Jun/19 03:37
• Updated: 21/Aug/19 07:57

Description

function __TObject:new(init_obj)
  local obj = {}
  if ttype(obj) == 'table' then
    obj = init_obj
  end

  -- Use the __parent key and the __index function to achieve inheritance
  obj.__parent = self
  setmetatable(obj, __TObject.__mt)
  return obj
end

In the above code in file Thrift.lua from lib lua in thrift project. I saw that it should check if init_obj is a table but this code is checking obj(a table as declare ?).

So i think the source must be 

function __TObject:new(init_obj)
  local obj = {}
  if ttype(init_obj) == 'table' then
    obj = init_obj
  end

  -- Use the __parent key and the __index function to achieve inheritance
  obj.__parent = self
  setmetatable(obj, __TObject.__mt)
  return obj
end

Issue Links

• links to: GitHub Pull Request #1809