[THRIFT-4852] The recv function of void functions doesn't throw custom exceptions

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 0.12.0
• Component/s: Lua - Compiler
• Assignee: Unassigned
• Reporter: Yu Gan
• Created: 25/Apr/19 20:04
• Updated: 01/Aug/19 01:00

Description

In thrift/compiler/cpp/src/thrift/generate/t_lua_generator.cc:621, it only throws custom exceptions when the function is not void. However, void function could still return exceptions to the caller service, as long as the function is not oneway.

// Return the result if it's not a void function
      if (!(*f_iter)->get_returntype()->is_void()) {
        out << indent() << "if result.success ~= nil then" << endl << indent() << "  return result.success"
            << endl;

        // Throw custom exceptions
        const std::vector<t_field*>& xf = (*f_iter)->get_xceptions()->get_members();
        vector<t_field*>::const_iterator x_iter;
        for (x_iter = xf.begin(); x_iter != xf.end(); ++x_iter) {
          out << indent() << "elseif result." << (*x_iter)->get_name() << " then" << endl
              << indent() << "  error(result." << (*x_iter)->get_name() << ")" << endl;
        }

        out << indent() << "end" << endl << indent()
            << "error(TApplicationException:new{errorCode = "
            << "TApplicationException.MISSING_RESULT})" << endl;
      }