Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-485

Generated validate methods that reference external thrift files' types are not referenced correctly

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.1, 0.2
    • Fix Version/s: 0.2
    • Component/s: Ruby - Compiler
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      If you have an enum in one thrift file and a struct with a field of that enum in another thrift file, the generated ruby code will try to validate the field's value against the enum's class, but without the namespace, resulting in errors.

      Also, I found one other place where we should use the fully qualified type name instead of just the type name - when rendering constants of a struct.

        Attachments

        1. thrift-485.patch
          1 kB
          Bryan Duxbury

          Activity

            People

            • Assignee:
              bryanduxbury Bryan Duxbury
              Reporter:
              bryanduxbury Bryan Duxbury
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: