[THRIFT-4797] Generated Go code produces name collisions on imports

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.12.0
• Fix Version/s: 0.13.0
• Component/s: Go - Compiler
• Assignee: Unassigned
• Reporter: Josh Yudaken
• Created: 11/Feb/19 22:22
• Updated: 16/Oct/19 22:27
• Resolved: 29/Jun/19 06:09

Description

If two modules have the same name, the produced go code will not compile.

For example:

import (
  "github.com/sample/project/common"
  "github.com/different/thing/common"
)

In go the final component (commons) is used as the name so there is a collision.

This can be fixed by aliasing the modules

import (
  common_1 "github.com/sample/project/common"
  common_2 "github.com/different/thing/common"
)

 

Issue Links

• links to: GitHub Pull Request #1811