Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4729

Crash: ForceClose expired task with Exception uncaught

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 0.8
    • 0.10.0
    • C++ - Library
    • None

    Description

      Context is: I've employed NonblockingServer & ThreadManager, with setTaskExpireTime() used in my app. Under heavy load, it crashed. Crash point is forceClose()::throw TException (to be specific, send(NotificationSocketFD) failed).
      I went through the code, noted that during removeExpiredTasks() there is no try-catch involved. On the contrary, Task::run() is enclosed by try-catch.

      Is it by design, or just a bug ? Thanks.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            jking3 James E. King III
            keguang KG.Xu
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment