[THRIFT-4725] Change Return Type Signature of Process Methods

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.11.0
• Fix Version/s: 0.13.0
• Component/s: Java - Library
• Labels: Breaking-Change
• Assignee: James E. King III
• Reporter: David Mollitor
• Created: 06/Jan/19 20:05
• Updated: 16/Oct/19 22:27
• Resolved: 14/Jan/19 21:55

Description

The method signature of TProcessor and TAsyncProcessor is:

 

public boolean process(...) throws TException;

It's not clear what the return value here because there is no documentation, but parts of the code do not even bother checking the return value. All of the returns, save one, are hard-coded to true. If there is a problem, code should throw an Exception. Make this a void method.

Note: This the method signature in other languages is also a boolean.

Issue Links

• links to: GitHub Pull Request #1678