[THRIFT-4711] Improve Immutable None Type Instantiation

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.12.0
• Fix Version/s: 0.13.0
• Component/s: Java - Library
• Flags: Patch
• Assignee: James E. King III
• Reporter: David Mollitor
• Created: 01/Jan/19 19:40
• Updated: 16/Oct/19 22:27
• Resolved: 02/Jan/19 15:06

Description

Option.java

    public static <T> Option<T> fromNullable(T value) {
        if (value != null) {
            return new Some<T>(value);
        } else {
            return new None<T>();
        }
    }

The None class is an immutable object, therefore it does not need to be instantiated for every call to fromNullable. Do the same thing as Java's Collections.emptyList() to allow for a single static instance of None to return.

https://github.com/openjdk-mirror/jdk7u-jdk/blob/master/src/share/classes/java/util/Collections.java#L3178-L3180

Issue Links

• links to: GitHub Pull Request #1663