[THRIFT-4695] Pre-Size Java Collections in Union

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.12.0
• Fix Version/s: 0.13.0
• Component/s: Java - Library
• Patch Info: Patch Available
• Assignee: James E. King III
• Reporter: David Mollitor
• Created: 28/Dec/18 22:57
• Updated: 16/Oct/19 22:26
• Resolved: 31/Dec/18 03:39

Description

One of these methods is not like the other (collections are pre-sized).

TUnion.java

  private static Map deepCopyMap(Map<Object, Object> map) {
    Map copy = new HashMap();
    for (Map.Entry<Object, Object> entry : map.entrySet()) {
      copy.put(deepCopyObject(entry.getKey()), deepCopyObject(entry.getValue()));
    }
    return copy;
  }

  private static Set deepCopySet(Set set) {
    Set copy = new HashSet();
    for (Object o : set) {
      copy.add(deepCopyObject(o));
    }
    return copy;
  }

  private static List deepCopyList(List list) {
    List copy = new ArrayList(list.size());
    for (Object o : list) {
      copy.add(deepCopyObject(o));
    }
    return copy;
  }

Issue Links

• links to: GitHub Pull Request #1656