[THRIFT-4680] TBufferTransports.h does not compile under Visual Studio 2017

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 0.11.0
• Fix Version/s: 0.12.0
• Component/s: C++ - Library

Environment

Visual Studio 2017

• Assignee: James E. King III
• Reporter: Sebastian Stüker
• Created: 17/Dec/18 20:45
• Updated: 27/Dec/18 15:24
• Resolved: 18/Dec/18 15:18

Description

When compiling under Windows 10 and including TBufferTransports.h, compilation fails with

Error    C2589    '(': illegal token on right side of '::' (compiling source file [...])  [...]\thrift-0.11.0\lib\cpp\src\thrift\transport\tbuffertransports.h    452

The error seems to be caused by the fact that in windows.h a macro max is defined.

Possible work arounds are to define NOMINMAX in order to prevent windows.h to define the macro max.

Alternatively, before the statement on line 452 undefine the macro

#undef max
maxBufferSize_ = std::numeric_limits<uint32_t>::max()

However, I would prefer a version, where it is checked whether max is defined as a macro, and if so, to use the other, correct syntax for this case of:

maxBufferSize_ = (std::numeric_limits<uint32_t>::max)();

 

Issue Links

• links to: GitHub Pull Request #1648