[THRIFT-4659] golang race detected when closing listener socket

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.11.0
• Fix Version/s: 0.12.0
• Component/s: Go - Library
• Assignee: Duru Can Celasun
• Reporter: Jay Gheewala
• Created: 05/Nov/18 23:39
• Updated: 27/Dec/18 15:24
• Resolved: 11/Dec/18 08:46

Description

Race condition is deteced for following write/read

 

git.apache.org/thrift.git/lib/go/thrift/server_socket.go:119

git.apache.org/thrift.git/lib/go/thrift.(*TServerSocket).Close()

git.apache.org/thrift.git/lib/go/thrift/server_socket.go:122

git.apache.org/thrift.git/lib/go/thrift.(*TServerSocket).Interrupt()

 

git.apache.org/thrift.git/lib/go/thrift.(*TServerSocket).Accept()

git.apache.org/thrift.git/lib/go/thrift/server_socket.go:78

git.apache.org/thrift.git/lib/go/thrift.(*TSimpleServer).innerAccept()

git.apache.org/thrift.git/lib/go/thrift/simple_server.go:129

git.apache.org/thrift.git/lib/go/thrift.(*TSimpleServer).AcceptLoop()

Issue Links

• links to: GitHub Pull Request #1645