[THRIFT-4658] Rust's TBinaryInputProtocol fails when strict is false

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.11.0
• Fix Version/s: 0.12.0
• Component/s: Rust - Library

Environment

 

`rustup show` output:

Default host: x86_64-apple-darwin

installed toolchains

--------------------

stable-x86_64-apple-darwin

nightly-x86_64-apple-darwin

active toolchain

----------------

stable-x86_64-apple-darwin (default)

rustc 1.30.0 (da5f414c2 2018-10-24)

• Assignee: Allen George
• Reporter: J W
• Created: 04/Nov/18 10:46
• Updated: 27/Dec/18 15:24
• Resolved: 05/Nov/18 12:59

Description

When use `TBinaryInputProtocol::new(..., false)`, any trivial example will fail:

service TestService

{ bool Test() }

 

Problem is here:

https://github.com/apache/thrift/blob/master/lib/rs/src/protocol/binary.rs#L126

with_capacity() allocates space, but len() of resulting Vec<> is 0.  read_exact() reads 0 bytes and read_byte() below receives first byte of the string which may or may not convert to TMessageType.

Change it to:
let mut name_buf: Vec<u8> = vec![0; name_size];
 

 

Issue Links

• links to: GitHub Pull Request #1620