[THRIFT-4652] Some go documentation on the website needs to be updated

• Type: Documentation
• Status: Closed
• Priority: Minor
• Resolution: Done
• Affects Version/s: 0.11.0
• Component/s: Go - Library, Website

Environment

macOS 10.14 

Go 1.11.1 darwin/amd64

Thrift 0.11.0

 

 

• Assignee: James E. King III
• Reporter: Tristian Azura
• Created: 17/Oct/18 05:54
• Updated: 05/Jan/19 14:36
• Resolved: 05/Jan/19 14:36

Description

The Go compiler generates invalid code for Thrift services, more specifically, calls to the `thrift.TProtocol`'s `Flush()` method are missing the `context.Context` argument:

edam/NoteStore.go:18963:14: not enough arguments in call to oprot.Flush
have ()
want (context.Context)
edam/NoteStore.go:18980:16: not enough arguments in call to oprot.Flush
have ()
want (context.Context)
edam/NoteStore.go:18999:16: not enough arguments in call to oprot.Flush
have ()
want (context.Context)
edam/NoteStore.go:19014:24: not enough arguments in call to oprot.Flush
have ()
want (context.Context)
edam/NoteStore.go:19035:16: not enough arguments in call to oprot.Flush
have ()
want (context.Context)
edam/NoteStore.go:19054:16: not enough arguments in call to oprot.Flush
have ()
want (context.Context)
edam/NoteStore.go:19069:24: not enough arguments in call to oprot.Flush
have ()
want (context.Context)
edam/NoteStore.go:19090:16: not enough arguments in call to oprot.Flush
have ()
want (context.Context)
edam/NoteStore.go:19111:16: not enough arguments in call to oprot.Flush
have ()
want (context.Context)
edam/NoteStore.go:19126:24: not enough arguments in call to oprot.Flush
have ()
want (context.Context)

 

I used the following models:

 * https://github.com/evernote/evernote-thrift

 

 

Issue Links

• links to: GitHub Pull Request #1612