[THRIFT-465] ThreadFactoryTests.h increments iterator after erasing the element to which it refers

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.1
• Fix Version/s: 0.2
• Component/s: Test Suite

Environment

Mac OS X 10.5.6

• Patch Info: Patch Available
• Assignee: Unassigned
• Reporter: Rush Manbert
• Created: 22/Apr/09 22:49
• Updated: 01/Nov/11 02:51
• Resolved: 04/Jun/09 00:33

Description

In lib/cpp/src/consurrency/test/ThreadFactoryTests.h the reapNThreads() function has this loop:
for (std::set<shared_ptr<Thread> >::const_iterator thread = threads.begin(); thread != threads.end(); thread++)

{ threads.erase(*thread); }

but erasing the element from the container invalidates all iteratots that point to that element, so this may result in undefined behavior.

I believe the equivalent is this:
while (!threads.empty())

{ threads.erase (*(threads.begin())); }

although it really seems like you could just call threads.clear() as well and forgo the loop. But maybe there's some subtlety here that I'm missing.