[THRIFT-4644] Compiler cannot be compiled on macOS(maybe also on other platforms with clang)

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 0.12.0
• Fix Version/s: 0.12.0
• Component/s: Compiler (General)

Environment

macOS High Sierra 10.13.5

Apple LLVM version 9.0.0 (clang-900.0.39.2)

• Patch Info: Patch Available
• Assignee: James E. King III
• Reporter: Tsuzuki Tsuchiya
• Created: 02/Oct/18 13:54
• Updated: 27/Dec/18 15:24
• Resolved: 03/Oct/18 11:57

Description

I tried to compile the thrift compiler of 014f53f on macOS, but I could not.

This is an error message I got.

src/thrift/generate/t_py_generator.cc:338:25: error: 't_py_generator::lang_keywords' hides overloaded virtual function [-Werror,-Woverloaded-virtual]

  std::set<std::string> lang_keywords() {

                        ^

./src/thrift/generate/t_generator.h:106:33: note: hidden overloaded virtual function 't_generator::lang_keywords' declared here: different qualifiers (const vs none)

  virtual std::set<std::string> lang_keywords() const;

                                ^

1 error generated.

Issue Links

• links to: GitHub Pull Request #1601