[THRIFT-4641] TCurlClient doesn't check for HTTP status code

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.11.0
• Fix Version/s: 0.12.0
• Component/s: PHP - Library
• Patch Info: Patch Available
• Flags: Patch
• Assignee: James E. King III
• Reporter: Josip Sokcevic
• Created: 20/Sep/18 18:36
• Updated: 27/Dec/18 15:25
• Resolved: 21/Sep/18 17:27

Description

TCurlClient doesn't check for HTTP status code. Other languages, such as Go and Java do check for it. This can lead to potentially wrong exception being thrown: TProtocolException instead of TTransportException. To be more precise, TCurlTransport doesn't error out and Protocol starts to parse response, which may lead to TProtocolException. For example, AWS ALB may return 502 Bad Gateway with HTML as part of payload when there's an issue with an upstream. In such case, a client may want to retry but it only makes sense if there's a transport exception.

Issue Links

• links to: GitHub Pull Request #1598