[THRIFT-4600] Don't close the connection in flush for python THttpClient.py

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 0.11.0
• Component/s: Python - Library
• Patch Info: Patch Available
• Flags: Patch
• Assignee: Unassigned
• Reporter: Finn Isaac Norris Colman
• Created: 15/Jul/18 23:44
• Updated: 04/Oct/20 02:05

Description

In thrift/lib/py/src/transport/THttpClient.py in the flush method it closes and reopens the connection:

if self.isOpen():
    self.close()
self.open()

 

This code is closing the connection on every flush request. The flush request occurs for every message send, which means that keep alive cannot be used. Removing this code from flush means that keep alive can be used as the user now has control over when the connection is closed.

Issue Links

• is caused by: THRIFT-155 Python THttpClient should handle opening HTTP layer on each request automatically
• links to: GitHub Pull Request #1572
• links to: GitHub Pull Request #2204