Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4600

Don't close the connection in flush for python THttpClient.py

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 0.11.0
    • Fix Version/s: None
    • Component/s: Python - Library
    • Labels:
      None
    • Patch Info:
      Patch Available
    • Flags:
      Patch

      Description

      In thrift/lib/py/src/transport/THttpClient.py in the flush method it closes and reopens the connection:

      if self.isOpen():
          self.close()
      self.open()

       

      This code is closing the connection on every flush request. The flush request occurs for every message send, which means that keep alive cannot be used. Removing this code from flush means that keep alive can be used as the user now has control over when the connection is closed.

        Attachments

        1. 1572.patch
          0.7 kB
          Finn Isaac Norris Colman

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                thefunster Finn Isaac Norris Colman
              • Votes:
                1 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 10m
                  10m