[THRIFT-4524] .NET Core Server doesn't close properly when cancelled

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.11.0
• Fix Version/s: 0.12.0
• Component/s: netcore - Library

Environment

Windows 10 Surface Pro 4. Xamarin.Forms app.  .NET Standard 2.0 libraries.

• Assignee: James E. King III
• Reporter: Stephen Starkie
• Created: 20/Mar/18 10:07
• Updated: 02/Feb/19 13:47
• Resolved: 20/Mar/18 20:32

Description

My code starts a server with a cancellation token and then later stops it by triggering the token.  When it does, the server fails to close cleanly and my code cannot then start another server on the same port.  The problem is that the Task which is responsible for opening and closing the connection in AsyncBaseServer throws a TokenCancelationException in the Task.Delay call which is not caught and therefore bombs out the task without closing the socket.  I will raise a pull request with a fix.

Issue Links

• links to: GitHub Pull Request #1512