[THRIFT-4516] Add support for go 1.10

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.11.0
• Fix Version/s: 0.12.0
• Component/s: Go - Library

Environment

ubuntu-artful (using go 1.10 instead of 1.9)

• Assignee: Duru Can Celasun
• Reporter: James E. King III
• Created: 12/Mar/18 17:33
• Updated: 27/Dec/18 15:25
• Resolved: 16/Mar/18 08:15

Description

Currently go 1.10 has additional type checking on format strings that prevent thrift from compiling and running tests.  We are limited to go 1.9 until this is resolved.

Example:

thrift/protocol_test.go:442: Errorf format %s has arg thelen of wrong type int
thrift/protocol_test.go:447: Errorf format %q has arg v of wrong type float64
thrift/protocol_test.go:451: Errorf format %q has arg v of wrong type float64
thrift/protocol_test.go:454: Errorf format %q has arg value of wrong type float64
thrift/protocol_test.go:482: Errorf format %s has arg thelen of wrong type int
thrift/protocol_test.go:491: Errorf format %d has arg v of wrong type string

gopath/src/dontexportrwtest/compile_test.go:32: Sprintf format %v arg s.read is a func value, not called
gopath/src/dontexportrwtest/compile_test.go:33: Sprintf format %v arg s.write is a func value, not called
gopath/src/dontexportrwtest/compile_test.go:36: Sprintf format %v arg is.read is a func value, not called
gopath/src/dontexportrwtest/compile_test.go:37: Sprintf format %v arg is.write is a func value, not called

 

Issue Links

• relates to: THRIFT-4448 Golang: do something with context.Context
• links to: GitHub Pull Request #1507