[THRIFT-4514] Remove pthread and boost::thread library support and use std::thread for C++11

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 0.11.0, 0.12.0
• Component/s: C++ - Compiler, C++ - Library
• Assignee: James E. King III
• Reporter: James E. King III
• Created: 10/Mar/18 15:05
• Updated: 11/Jan/19 14:17
• Resolved: 11/Jan/19 14:17

Description

We have a pretty awful thread class implementation:

1. The build system compiles in the right files to implement the class definition.
2. We support three thread libraries.

I want to simplify this, tremendously, to:

A. Remove the pthread implementation.
B. Remove the boost thread implementation.
C. Rename the std thread implementation (StdThreadFactory) to ThreadFactory
D. Have one thread class implementation!
E. Remove the WITH_STDTHREADS build time option as it will no longer be necessary.

In short:

• Support std::thread for C++11 or later
• Drop support for boost threads
• Drop support for native pthreads

We have a lot of branches and test conditionals that do special things with different thread implementations. We need to simplify and move forward to reduce the maintenance cost in this area.

Any objections?

Issue Links

• duplicates: THRIFT-4730 Remove pthread and boost::thread library support and use std::thread for C++11
• relates to: THRIFT-4720 Drop support for C++03/C++98 and begin refactoring