[THRIFT-4510] Regression in 0.11: Arrays with default values in python

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Duplicate
• Affects Version/s: 0.11.0
• Component/s: Python - Compiler
• Assignee: James E. King III
• Reporter: Jason Gauci
• Created: 07/Mar/18 00:08
• Updated: 04/Jan/19 16:48
• Resolved: 04/Jan/19 16:48

Description

We are getting reports from users that our project is broken on thrift 0.11.  Arrays with default values are newly broken in 0.11 because thrift_spec is not defined soon enough.

 

To reproduce:

 
brew install thrift
git clone https://github.com/caffe2/BlueWhale.git
cd BlueWhale
thrift --gen py --out . ml/rl/thrift/core.thrift
cat ml/rl/thrift/core/ttypes.py
 
Notice that the TrainingParameters._init_ tries to use thrift_spec to handle the default array when thrift_spec doesn't exist yet.  This results in this failure upon import:
 
AttributeError: 'TrainingParameters' object has no attribute 'thrift_spec'
 
The same thing works when using 0.10

Issue Links

• duplicates: THRIFT-4623 Python compiler generates inoperable definitions for default-valued classes in same thrift file
• is caused by: THRIFT-2642 Recursive structs don't work in python