[THRIFT-4507] TWaitableNamedPipeImpl::read race condition can cause hang in ~TWaitableNamedPipeImpl

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 0.11.0
• Component/s: C++ - Library
• Assignee: Unassigned
• Reporter: Jeremy Spiegel
• Created: 05/Mar/18 20:06
• Updated: 06/Mar/18 16:08

Description

If the other side of the pipe disconnects in between a call to endAsyncRead and beginAsyncRead, then the beginAsyncRead will throw, but 
~TWaitableNamedPipeImpl will hang inside GetOverlappedResult. Here is some test code that reproduces the issue:

    std::promise<void> serverStarted, clientStarted, serverReadStarted, clientDestroyed;
    std::thread serverThread([&] {
        auto server = boost::make_shared<apache::thrift::transport::TPipeServer>("pipe-test", 64 * 1024, 1);
        server->listen();
        serverStarted.set_value();
        auto serverConnection = server->accept();
        clientStarted.get_future().wait();
        uint8_t buf[1024];
        serverConnection->read(buf, 1);
        serverReadStarted.set_value();
        clientDestroyed.get_future().wait();
        try {
            serverConnection->read(buf, 1023);
        } catch (const apache::thrift::transport::TTransportException&) {
        }
    });

    serverStarted.get_future().wait();

    {
        auto client = boost::make_shared<apache::thrift::transport::TPipe>("pipe-test");
        client->open();
        uint8_t buf[1024]{};
        client->write(buf, 1024);
        clientStarted.set_value();
        serverReadStarted.get_future().wait();
    }
    clientDestroyed.set_value();
    serverThread.join();