[THRIFT-4487] gettimeofday: windows implementation not quoting source, applying license to foreign code

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.13.0
• Component/s: C++ - Library
• Labels: copyright license
• Assignee: James E. King III
• Reporter: Marcus Müller
• Created: 06/Feb/18 20:13
• Updated: 16/Oct/19 22:26
• Resolved: 14/Jan/19 14:56

Description

https://github.com/apache/thrift/blob/master/lib/cpp/src/thrift/windows/GetTimeOfDay.cpp

uses Code that is at least from March 2007; unless the original author of GetTimeOfDay.cpp is the same who submitted the code to http://www.openasthra.com/wp-content/uploads/gettimeofday.c (link dead, web archive link: https://web.archive.org/web/20070328134250/http://www.openasthra.com/wp-content/uploads/gettimeofday.c ), very likely isn't code that can be assigned to the Apache foundation.

I can't really tell when this file has been added. 

Issue Links

• links to: GitHub Pull Request #1693