Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4486

Golang: -remote.go client cleanup

    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.11.0
    • Fix Version/s: 0.12.0
    • Component/s: Go - Compiler
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      PR Here: https://github.com/apache/thrift/pull/1488

      There are a few issues with the generated -remote.go clients, fixed in the above PR.

      • (bug) CLI input is decoded with TSimpleJsonProtocol which does not support json->thrift serialization (see also) (so there is no way to input data)
      • (bug) *-remote.go files for generated Thrift packages with no services fail to compile since client is unused. (also these -remote.go files are not useful if there are no services)
      • (bug) https urls fail (since the useHttp check only checks for "http")
      • (feature) Http headers aren't supported, so servers with header auth cannot be used

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                jking3 James E. King III
                Reporter:
                johnboiles John Boiles
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: