[THRIFT-4486] Golang: -remote.go client cleanup

• Type: Task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.11.0
• Fix Version/s: 0.12.0
• Component/s: Go - Compiler
• Patch Info: Patch Available
• Assignee: James E. King III
• Reporter: John Boiles
• Created: 02/Feb/18 04:58
• Updated: 27/Dec/18 15:25
• Resolved: 03/Mar/18 18:20

Description

PR Here: https://github.com/apache/thrift/pull/1488

There are a few issues with the generated -remote.go clients, fixed in the above PR.

• (bug) CLI input is decoded with TSimpleJsonProtocol which does not support json->thrift serialization (see also) (so there is no way to input data)
• (bug) *-remote.go files for generated Thrift packages with no services fail to compile since client is unused. (also these -remote.go files are not useful if there are no services)
• (bug) https urls fail (since the useHttp check only checks for "http")
• (feature) Http headers aren't supported, so servers with header auth cannot be used

Issue Links

• links to: GitHub Pull Request #1488