[THRIFT-4480] NodeJS warning on binary_protocol writeMessageEnd when seqid = 0

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.11.0
• Fix Version/s: 0.12.0
• Component/s: Node.js - Library
• Assignee: James E. King III
• Reporter: Brian Forbis
• Created: 30/Jan/18 15:00
• Updated: 27/Dec/18 15:25
• Resolved: 06/Mar/18 23:28

Description

The nodeJS implementation of binary protocol has some internal state that keeps track of the `seqid` between calls to `writeMessageBegin` and `writeMessageEnd`. There is a line that will emit a warning if the seqid can't be unset:

TBinaryProtocol.prototype.writeMessageEnd = function() {
    if (this._seqid) {
        this._seqid = null;
    } else {
        log.warning('No seqid to unset');
    }
};

 

but it does not take into account that the seqid can be set to "0" which is a falsey value. This causes warnings to be emitted for valid messages.

This bug can be reproduced by connecting a perl client to a nodeJS server. Perl will always send a sequenceID of 0, causing the warning to occur every time the node server responds to an RPC request.

 

Even though this warn line has been in the nodeJS library for several releases, the bug only affects thrift version 11 because until that version the logger had not been implemented yet and would swallow all warnings.

 

Issue Links

• relates to: THRIFT-4405 Incorrect handling of sequence numbers that wrap to negative
• links to: GitHub Pull Request #1487