[THRIFT-4468] Make the class TGUIConsole thread-safe

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Not A Problem
• Affects Version/s: 0.11.0
• Fix Version/s: 0.12.0
• Component/s: Delphi - Library
• Assignee: Jens Geyer
• Reporter: Anton Shchyrov
• Created: 22/Jan/18 14:29
• Updated: 27/Dec/18 15:24
• Resolved: 25/Jan/18 23:16

Description

In Delphi all methods that refer to VCL should do it only from main thread. But class TGUIConsole despite the name does not contain any synchronization methods.

My suggestion is to rename this class to TStringsConsole, make method InternalWrite virtual and make new class TGUIConsole inherits from TStringsConsole

 

TGUIConsole = class( TStringsConsole )
protected
   procedure InternalWrite(const S: string; bWriteLine: Boolean); override;
end;
{ TGUIConsole }
procedure TGUIConsole.InternalWrite(const S: string; bWriteLine: Boolean);
 begin
   if TThread.CurrentThread.ThreadID <> MainThreadID then begin
     TThread.Synchronize(nil, procedure
       begin
         inherited InternalWrite(S, bWriteLine);
       end
     );
   end else
     inherited InternalWrite(S, bWriteLine);
 end;