[THRIFT-4462] First line in Console duplicated

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.11.0
• Fix Version/s: 0.12.0
• Component/s: Delphi - Library
• Patch Info: Patch Available
• Assignee: Jens Geyer
• Reporter: Anton Shchyrov
• Created: 17/Jan/18 17:46
• Updated: 27/Dec/18 15:25
• Resolved: 19/Jan/18 18:25

Description

Method Console.Write/WriteLine in class TGUIConsole after called method Write and clear log duplicates current message

 

ChangeConsole(TGUIConsole.Create(Memo1.Lines));
Console.Write('String');  // Set internal FLineBreak to False
Memo1.Lines.Clear;
Console.Write('Some String');  // Log have "Some StringSome String"
Reason in method 
procedure TGUIConsole.InternalWrite(const S: string; bWriteLine: Boolean);
var
  idx : Integer;
begin
  if FLineBreak then
  begin
    FMemo.Add( S );
  end else
  begin
    idx := FMemo.Count - 1;
    if idx < 0 then
    begin
      FMemo.Add( S );
    end;
    FMemo[idx] := FMemo[idx] + S;
  end;
  FLineBreak := bWriteLine;
end; 

If FMemo.Count = 0 then idx = -1 and string added to log. But next line

FMemo[idx] := FMemo[idx] + S;

repeats the added string. should be

    if idx < 0 then
     begin
       FMemo.Add( S );
     end else
       FMemo[idx] := FMemo[idx] + S;