[THRIFT-4445] PHP TSocket broken by THRIFT-4295

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Invalid
• Affects Version/s: 0.11.0
• Component/s: PHP - Library
• Assignee: James E. King III
• Reporter: Stig Bakken
• Created: 08/Jan/18 15:28
• Updated: 08/Jan/18 15:33
• Resolved: 08/Jan/18 15:33

Description

Thrift version 0.11.0 introduces an issue with PHP's TSocket, where it sets SO_NODELAY by default, with no way of disabling. 0.11.0 is unusable for us because of this, as we open tens or hundreds of connections per second to localhost from PHP, and with 0.11.0 we run out of client ports in a matter of seconds.

The default behaviour should be to not touch SO_NODELAY unless there is a good reason to do so! See for example https://www.extrahop.com/company/blog/2016/tcp-nodelay-nagle-quickack-best-practices/#5