[THRIFT-4373] Extending Thrift class results in "Attempt serialize from non-Thrift object"

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.10.0
• Fix Version/s: 0.12.0
• Component/s: PHP - Library

Environment

Linux 4.13.3-1-ARCH
PHP 7.1.10

• Patch Info: Patch Available
• Flags: Patch
• Assignee: James E. King III
• Reporter: Josip Sokcevic
• Created: 25/Oct/17 20:09
• Updated: 27/Dec/18 15:25
• Resolved: 09/Apr/18 12:47

Description

This happens when using php extension. thrift_protocol_write_binary will check Z_TYPE_P of spec and expects to be array (IS_ARRAY). However, PHP7 will set it as reference (IS_REFERENCE).

Example:

$s = new Serializer\TBinarySerializer();

// Foo is a Thrift type class
class FooExtended extends Foo {}

$o = new Foo();
$o2 = new FooExtended();

// this works just fine:
$s->serialize($o); // this uses thrift_protocol_write_binary if available

// Next line throws \Thrift\Exception\TProtocolException if thrift_protocol_write_binary is used
// However, it doesn't break if no extension is available.
$s->serialize($o);

Proposed solution is to dereference using ZVAL_DEREF before checking types (attached). Alternative would be to mark struct type classes as final, but that break compatibility.

Issue Links

• links to: GitHub Pull Request #1401
• links to: GitHub Pull Request #1401