[THRIFT-4320] Use interface instead of strict http.Client type in THttpClientOptions

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Information Provided
• Component/s: Go - Library
• Assignee: Unassigned
• Reporter: Marek Brysa
• Created: 08/Sep/17 07:27
• Updated: 03/Jan/19 14:41
• Resolved: 03/Jan/19 14:41

Description

THttpClientOptions (http_client.go) takes a strict http.Client type which disallows developers from customizing http.Client or providing their own implementation. I propose to replace this with an interface such as:

type HttpClient interface {
	Do(req *http.Request) (*http.Response, error)
}

Do() is the only function of http.Client that is used (in THttpClient.Flush()).