Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4270

Generate Erlang mapping functions for const maps and lists

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.10.0
    • Fix Version/s: 0.11.0
    • Component/s: Erlang - Compiler
    • Labels:
      None

      Description

      The Thrift Erlang compiler generates macros for consts. This is great for scalar types and structs. However the macro that is generated for a map is something like

      -define(CONSTANTS_DEMO_GEN_MAP, dict:from_list([{35532,233},{43523,853}])).
      

      This is not as useful as the other macros, because any use of this macro will generate the dict at run time. (It is possible to work around this issue by using the ct_expand parse transform.)

      It would be better to generate a function directly to do the transform. The function for the previous example would be

      gen_map(35532) -> 233;
      gen_map(43523) -> 853.
      

      Similarly, the macro that is generated for a list is something like:

      -define(CONSTANTS_DEMO_GEN_LIST, [235235,23598352,3253523]).
      

      This representation is fine if you want to iterate over the elements of the list, but is not efficient if you need to look an element because lists in Erlang are implemented as singly-linked lists. For lookups, it would be better to generate a tuple and then use element(N, Tuple) to extract the nth element.

      The thrift generator could generate a function to do the lookup:

      gen_list(N) -> element(N, {235235,23598352,3253523}).
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                dhull David Hull
                Reporter:
                dhull David Hull
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: