[THRIFT-4232] ./configure does bad ant version check

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.10.0
• Fix Version/s: 0.11.0
• Component/s: Build Process

Environment

OSX 10.12.5, running ant 1.10.1

• Assignee: James E. King III
• Reporter: David Woodward
• Created: 19/Jun/17 14:12
• Updated: 14/Dec/17 13:54
• Resolved: 21/Sep/17 16:21

Description

On line 18869 of the configure script, it checks that the ant version is >= 1.7. It uses some kind of string comparison. This breaks for my current ant version (1.10). It seems to think that 1.10 is not >= 1.7. I think this is because it's comparing strings without taking into account what the strings actually mean. Something like this might be a possible patch:

https://stackoverflow.com/questions/16989598/bash-comparing-version-numbers

This should be fixed because it means that people with new ant versions can't build the java thrift library.

Also it should be checked to see if other parts of the configure process are using these kinds of faulty version checks.

Issue Links

• is duplicated by: THRIFT-4109 Configure Script uses string comparison for versions
• links to: GitHub Pull Request #1354