[THRIFT-4182] separate loggers for client and server errors

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: Java - Library
• Assignee: Unassigned
• Reporter: Sergey Shelukhin
• Created: 25/Apr/17 19:35
• Updated: 05/May/17 14:46

Description

As it stands, a malicious (or broken) client can flood the logs with callstacks, e.g.

2017-04-13 11:26:57,913 ERROR HiveServer2-Handler-Pool: Thread-96: server.TThreadPoolServer (TThreadPoolServer.java:run(297)) - Error occurred during processing of message.
java.lang.RuntimeException: org.apache.thrift.transport.TSaslTransportException: No data or no sasl data in the stream
at org.apache.thrift.transport.TSaslServerTransport$Factory.getTransport(TSaslServerTransport.java:219)
[snip]
Caused by: org.apache.thrift.transport.TSaslTransportException: No data or no sasl data in the stream
at org.apache.thrift.transport.TSaslTransport.open(TSaslTransport.java:328)
at org.apache.thrift.transport.TSaslServerTransport.open(TSaslServerTransport.java:41)
at org.apache.thrift.transport.TSaslServerTransport$Factory.getTransport(TSaslServerTransport.java:216)
... 10 more

Perhaps a class of exceptions should be introduced for client errors, then a separate catch block and a logger can be added so that these errors could be suppressed without suppressing all the logging for the class.