Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4158

minor issue in README-MSYS2.md

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.11.0
    • Fix Version/s: 0.11.0
    • Component/s: Build Process
    • Labels:
      None

      Description

      In README-MSYS2.md there are recommended cmake build flags:

          cmake -G"MinGW Makefiles" -DCMAKE_MAKE_PROGRAM=/mingw64/bin/mingw32-make \
             -DCMAKE_C_COMPILER=x86_64-w64-mingw32-gcc.exe \
             -DCMAKE_CXX_COMPILER=x86_64-w64-mingw32-g++.exe \
             -DWITH_BOOSTTHREADS=ON -DWITH_LIBEVENT=OFF \
             -DWITH_SHARED_LIB=OFF -DWITH_STATIC_LIB=ON \
             -DWITH_JAVA=OFF -DWITH_PYTHON=OFF -DWITH_PERL=OFF \
      

      However I think they are not really correct, or am I overlooking something?
      The options WITH_JAVA, WITH_PYTHON and WITH_PERL should be
      BUILD_JAVA, BUILD_PYTHON and BUILD_PERL, respectively. At least
      I could not find the WITH_XXX variants in CMakeLists.txt.
      The options CMAKE_MAKE_PROGRAM, CMAKE_C_COMPILER and
      CMAKE_CXX_COMPILER should be optional and not required. I think
      they are rather confusing since these compilers should be the default for
      a MINGW build shell.
      Finally, the readme recommends to install

          $ pacman -S bison flex openssl openssl-devel \
                      mingw-w64-x86_64-boost mingw-w64-x86_64-cmake \
                      mingw-w64-x86_64-toolchain zlib zlib-devel
      

      The openssl and zlib variants used here are from MSYS2, not MinGW64.
      If there is no strong reason to use those, I think its recommended to use
      the MinGW46 variants instead:

          $ pacman -S bison flex mingw-w64-x86_64-openssl \
                      mingw-w64-x86_64-boost mingw-w64-x86_64-cmake \
                      mingw-w64-x86_64-toolchain mingw-w64-x86_64-zlib
      

      My suggested options "build for me" so they come with at least a bit
      of testing...

        Attachments

          Activity

            People

            • Assignee:
              jking3 James E. King III
              Reporter:
              emmenlau Mario Emmenlauer
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: