[THRIFT-414] Support non-UTF-8 in Java and C#

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Won't Fix
• Component/s: C# - Compiler, C# - Library, Cocoa - Compiler, Cocoa - Library, Java - Compiler, Java - Library
• Assignee: Unassigned
• Reporter: David Reiss
• Created: 31/Mar/09 19:54
• Updated: 02/May/13 02:29
• Resolved: 03/Nov/10 08:51

Description

Java and C# Thrift assume that all strings should be UTF-8. A better approach would be:

• Give the readString and writeString protocol methods an encoding parameter, probably defaulting to UTF-8 for compatibility and convenience.
• Make generated struct readers and writers pass the argument to the protocol objects for each string.
• Allow a type annotation to override the default UTF-8 encoding.
• All other languages (except Python 3) should ignore the annotation, but it will serve as documentation for the application.

Issue Links

• depends upon: THRIFT-413 Type annotations for base types