[THRIFT-4140] Use of non-thread-safe function gmtime()

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.10.0
• Fix Version/s: 0.11.0
• Component/s: C++ - Library
• Patch Info: Patch Available
• Assignee: James E. King III
• Reporter: Adriaan Schmidt
• Created: 27/Mar/17 09:26
• Updated: 14/Dec/17 13:56
• Resolved: 24/Sep/17 16:13

Description

Method THttpServer::getTimeRFC1123() (in lib/cpp/src/thr8ft/transport/THttpServer.cpp) uses gmtime().
This function is documented to be not thread-safe (https://www.gnu.org/software/libc/manual/html_node/Broken_002ddown-Time.html).

Instead, we should use gmtime_r().

Issue Links

• links to: GitHub Pull Request #1231