Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-413

Type annotations for base types

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 0.2
    • None
    • None
    • Patch Available

    Description

      This patch allows type annotations to be applied to base types. The one thing about it that scared me a bit was that we were allocating a new type object for each base type with annotations, so checks like

      if (get_true_type(ttype) == g_type_i32)
      

      would fail if ttype had annotations. But I grepped for all uses of the global type objects and didn't find anything like that.

      Attachments

        Issue Links

          Activity

            People

              dreiss David Reiss
              dreiss David Reiss
              Votes:
              2 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: