Details
-
Improvement
-
Status: Closed
-
Minor
-
Resolution: Fixed
-
None
-
None
-
None
-
Patch Available
Description
This patch allows type annotations to be applied to base types. The one thing about it that scared me a bit was that we were allocating a new type object for each base type with annotations, so checks like
if (get_true_type(ttype) == g_type_i32)
would fail if ttype had annotations. But I grepped for all uses of the global type objects and didn't find anything like that.
Attachments
Attachments
Issue Links
- is depended upon by
-
THRIFT-414 Support non-UTF-8 in Java and C#
- Closed