[THRIFT-4131] Javascript with WebSocket handles oneway methods wrong

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 0.10.0
• Fix Version/s: 0.11.0
• Component/s: JavaScript - Compiler, JavaScript - Library

Environment

all

• Assignee: James E. King III
• Reporter: Martin Hejnfelt
• Created: 23/Mar/17 14:38
• Updated: 27/Jun/18 15:20
• Resolved: 25/Sep/17 03:36

Description

When using the WebSocket transport all client->server calls install a callback, and we depend on these callbacks being push()'ed and shift()'ed sequentially, however, oneway methods never gets a reply, and therefore the installed callback doesn't get removed, causing the callback array to get "out of synchronization" so to speak, and subsequent calls, now deal with the wrong callbacks, as data comes in.

To remedy this I changed the compiler/generator to send a null callback to the transport->flush method for oneway methods, and then in the WebSocket transport code, make a null check and only install defined callbacks. This seem to fix it for me. I can send in patches if necessary.

Issue Links

• relates to: THRIFT-3950 Memory leak while calling oneway method
• links to: GitHub Pull Request #1372