Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.2
    • Component/s: None
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      This patch allows type annotations to be applied to base types. The one thing about it that scared me a bit was that we were allocating a new type object for each base type with annotations, so checks like

      if (get_true_type(ttype) == g_type_i32)
      

      would fail if ttype had annotations. But I grepped for all uses of the global type objects and didn't find anything like that.

        Issue Links

          Activity

          David Reiss created issue -
          David Reiss made changes -
          Field Original Value New Value
          Attachment 0001-THRIFT-413.-Suppport-for-annotations-on-base-types.patch [ 12404203 ]
          David Reiss made changes -
          Link This issue blocks THRIFT-414 [ THRIFT-414 ]
          Hide
          Chad Walters added a comment -

          +1 lgtm

          Show
          Chad Walters added a comment - +1 lgtm
          Hide
          Esteve Fernandez added a comment -

          +1 This will make THRIFT-395 easier to solve.

          Show
          Esteve Fernandez added a comment - +1 This will make THRIFT-395 easier to solve.
          Hide
          Esteve Fernandez added a comment -

          This has got two positive comments from Chad and me, can I commit it or do you want to do it, David?

          Show
          Esteve Fernandez added a comment - This has got two positive comments from Chad and me, can I commit it or do you want to do it, David?
          Hide
          David Reiss added a comment -

          I can do it. I was just waiting because I have it on the same branch as the patch for THRIFT-414.

          Show
          David Reiss added a comment - I can do it. I was just waiting because I have it on the same branch as the patch for THRIFT-414 .
          David Reiss made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s 0.2 [ 12313769 ]
          Resolution Fixed [ 1 ]
          Esteve Fernandez made changes -
          Assignee David Reiss [ dreiss ]
          Jake Farrell made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Gavin made changes -
          Link This issue blocks THRIFT-414 [ THRIFT-414 ]
          Gavin made changes -
          Link This issue is depended upon by THRIFT-414 [ THRIFT-414 ]

            People

            • Assignee:
              David Reiss
              Reporter:
              David Reiss
            • Votes:
              2 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development