Details
-
Improvement
-
Status: Closed
-
Minor
-
Resolution: Fixed
-
None
-
None
Description
Currently Thrift structs are turned into Rust struct definitions that do not have an auto-derived Hash. We should auto-derive this trait.
The following behaviors should be checked:
- Can still derive Hash even if the struct contains a double
- Can still derive Hash even if the struct contains set<double>
- Can still derive Hash even if the struct contains map<double, double>
Basically, doubles are represented in the auto-generated code by OrderedFloat instead of f64 since we cannot derive a hash for, or order Rust floats. The resulting code should work even if doubles are contained any where in the structure.
Attachments
Issue Links
- links to