Details
-
Bug
-
Status: Closed
-
Major
-
Resolution: Fixed
-
0.10.0
-
None
Description
The thrift 0.10.0 distribution on PyPI does not include extension headers and a C++ (template) file, preventing the accelerated protocols from being built. pip install reports a brief error:
Running thrift-0.10.0/setup.py -q bdist_egg --dist-dir /tmp/easy_install-bVU8VN/thrift-0.10.0/egg-dist-tmp-ghJzGL cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++ src/ext/module.cpp:21:19: fatal error: types.h: No such file or directory #include "types.h" ^ compilation terminated. () ******************************************************************************** An error occurred while trying to compile with the C extension enabled Attempting to build without the extension now ******************************************************************************** ()
The list of files that is not included in the distribution is as follows. In addition to the headers and source file mentioned above, there's a Windows compatibility header missing and a couple of test files missing. It looks like there was a file extension filter (accidentally) applied to the C++ files at least:
src/ext/binary.h src/ext/compact.h src/ext/endian.h src/ext/protocol.h src/ext/protocol.tcc src/ext/types.h compat/win32/stdint.h test/_import_local_thrift.py test/thrift_json.py
jfarrell were you who made the release? Is it possible to hotfix? My team has been waiting on the release of the accelerated compact protocol for a while, this discovery is saddening for us.
Attachments
Attachments
Issue Links
- links to
