[THRIFT-4027] Compilation error with boost 1.63.0

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.10.0
• Fix Version/s: 0.11.0
• Component/s: C++ - Compiler

Environment

Boost 1.63.0

• Assignee: James E. King III
• Reporter: Benoit Sigoure
• Created: 11/Jan/17 07:43
• Updated: 07/Jan/19 13:34
• Resolved: 07/Jan/19 13:34

Description

It's kinda stupid but Boost.Test introduced a global variable called VERSION in one of their inline headers (in this commit) and this causes the build of Thrift 0.10.0 to fail with:

make[1]: Entering directory `/bld/thrift/Artools-rpmbuild/thrift-0.10.0/compiler/cpp/test'
g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src/thrift -I../../../lib/c_glib/src/thrift  -I/usr/include -I../../../compiler/cpp/src -I../../../lib/cpp/src -I../../../lib/cpp/src  -Wall -Wextra -pedantic -O2 -g -pipe -Wall -Wp,-D
_FORTIFY_SOURCE=2 -fexceptions -fstack-protector -fno-var-tracking -fno-var-tracking-assignments --param=ssp-buffer-size=4 -m32 -march=i686 -mtune=atom -fasynchronous-unwind-tables  -std=c++11 -c -o plugin/conversion_test.o plugin/convers
ion_test.cc
In file included from /usr/include/boost/test/included/unit_test.hpp:32:0,
                 from plugin/conversion_test.cc:28:
/usr/include/boost/test/impl/unit_test_parameters.ipp:102:12: error: expected unqualified-id before string constant
 std::string VERSION           = "version";
            ^