Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3972

C++ Library NoStarveReadWriteMutex helgrind identified race

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Reopened
    • Minor
    • Resolution: Unresolved
    • 0.10.0
    • None
    • C++ - Library
    • None

    Description

      An issue from THRIFT-3038 was split out so it could be completed.
      There is a class in the project called NoStarveReadWriteMutex which is unused in the project.
      It has a unit test (RWMutexStarveTest).

      helgrind identified that there is a race in the handling of the volatile boolean in this class.

      I would prefer to just remove NoStarveReadWriteMutex as it is not used by the project, however doing so would require refactoring the RWMutexStarveTest because it ends up testing ReadWriteMutex, which is used by something in contrib/fb303.

      Attachments

        Activity

          People

            Unassigned Unassigned
            jking3 James E. King III
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: