[THRIFT-3929] PHP "nsglobal" Option Results in Syntax Error in Generated Code (Trailing Backslash)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.3
• Fix Version/s: 0.10.0
• Component/s: PHP - Compiler
• Labels: easyfix

Environment

Distributor ID: Ubuntu
Description: Ubuntu 14.04.4 LTS
Release: 14.04
Codename: trusty

• Assignee: Ben Meynell
• Reporter: Ben Meynell
• Created: 14/Sep/16 23:21
• Updated: 28/Sep/16 13:28
• Resolved: 25/Sep/16 17:29

Description

thrift --gen php:server,psr4,oop,validate,json,nsglobal="My\Special\Place" -out ./src my.thrift

Results in PHP files with namespaces defined as:

namespace My\Special\Place\;

Note the trailing backslash ("\"). This results in unparseable PHP:

$ php -l src/My/Special/Place/Data.php
Errors parsing src/My/Special/Place/Data.php

The fix is to simply omit the trailing backslash from the generated code.

Issue Links

• links to: GitHub Pull Request #1089