Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3920

Ruby: Ensuring that HTTP failures will clear the http transport outbuf var

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.9.3
    • Fix Version/s: 0.10.0
    • Component/s: Ruby - Library
    • Labels:
      None

      Description

      PR: https://github.com/apache/thrift/pull/1048

      With the current implementation, any Net HTTP failure will raise from the #flush() method without resetting the @outbuf variable.

      I think that resetting the @outbuf on these failures is more "expected" behaviour. Especially if there is a malformed request that the downstream server does not want to/can't handle. As far as I can tell, there is not way to clear the @outbuf var apart from the #flush() method, so if that fails, then you will just keep appending requests to the out buffer.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                hashtagjohnt John
                Reporter:
                hashtagjohnt John
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: