[THRIFT-3915] PSR(PHP Standard Recommendation) Conformance Violation

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 0.9.3
• Component/s: Compiler (General)
• Labels: build

Environment

Any

• Assignee: James E. King III
• Reporter: Juwon Kim
• Created: 02/Sep/16 08:08
• Updated: 04/Jan/19 03:09
• Resolved: 24/Sep/17 14:25

Description

Hi there? I'm a server guy in Korea, mainly focuses on PHP development. I'm leaving this issue to let you know that Thrift-generated code violates PSR(PHP Standard Recommendation). And I'm asking you to follow the PHP community rules.

I started using Apache Thrift a couple of days ago, I found out that Thrift-generated code does not follow PSR-1. In a nutshell a PHP file should contain only one class(http://www.php-fig.org/psr/psr-1/#3-namespace-and-class-names), but Thrift-generated one has many.

The problem is that Thrift-generated classes cannot be autoloadable through PSR-4 autoload standard(http://www.php-fig.org/psr/psr-4/#3-examples). The workaround is writing a home-made autoloading logic, or taking advantage of symbolic link like https://github.com/appkr/psr4-autoload-test/ . Which is not elegant anyway.

So I would like you to study the voice of PHP users on the importance of PSR.
I hope to see your opinion soon.

Thanks,

appkr.

Issue Links

• duplicates: THRIFT-3046 Allow PSR4 class loading for generated classes (PHP)