Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3904

Typo in node tutorial leads to wrong transport being used

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: Node.js - Library, Tutorial
    • Labels:
      None

      Description

      In the node tutorial (tutorial/nodejs/NodeClient.js), lines like `transport = thrift.TBufferedTransport()` cause transport to be undefined, which later get replaced with the default, so this example does work.

      I found the issue when using `thrift.TFramedTransport()`, which was erroring on the server side. It took me a while to figure out that the transport was falling back to buffered, because I was actually assigning the transport to undefined.

      Changing the lines to assign thrift.TFramedTransport instead of thrift.TFramedTransport() fixed it for me.

        Attachments

          Activity

            People

            • Assignee:
              kedzie Marek Kedzierski
              Reporter:
              msonnabaum Mark Sonnabaum
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: