Thrift
  1. Thrift
  2. THRIFT-387

Add appropriate Apache header to all code files

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.2
    • Component/s: None
    • Labels:
      None

      Description

      We need to get the Apache header on all code files before we go to our release.

        Activity

        Jake Farrell made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Todd Lipcon made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Assignee Jérémie BORDIER [ ahfeel ] Todd Lipcon [ tlipcon ]
        Fix Version/s 0.2 [ 12313769 ]
        Fix Version/s 0.1 [ 12313284 ]
        Resolution Fixed [ 1 ]
        Hide
        Todd Lipcon added a comment -

        This got covered in THRIFT-622. I am 99.9% sure we are all kosher now. Thanks for the work, everyone.

        Show
        Todd Lipcon added a comment - This got covered in THRIFT-622 . I am 99.9% sure we are all kosher now. Thanks for the work, everyone.
        Hide
        Joe Schaefer added a comment -

        secretary@a.o would be ideal. I can't find any records in ICLAs, CCLAs or grants for William Morgan
        or adap.tv.

        Show
        Joe Schaefer added a comment - secretary@a.o would be ideal. I can't find any records in ICLAs, CCLAs or grants for William Morgan or adap.tv.
        Hide
        David Reiss added a comment -

        I'm in contact with the guys from imeem. If you can tell me the best place for them to email the docs, I can pass the instructions along. (They have already sent them in at least once.)

        William Morgan sent in a CCLA from his company. Is it possible to check on the status of this? (I assume it is adap.tv.)

        I just emailed Patrick and Simon again. I'll let you know how it goes.

        Show
        David Reiss added a comment - I'm in contact with the guys from imeem. If you can tell me the best place for them to email the docs, I can pass the instructions along. (They have already sent them in at least once.) William Morgan sent in a CCLA from his company. Is it possible to check on the status of this? (I assume it is adap.tv.) I just emailed Patrick and Simon again. I'll let you know how it goes.
        Hide
        Joe Schaefer added a comment -

        We have a CLA from Andrew Lutomirski, and I've spoken
        with Ben Matasar about resubmitting. No word on the others.

        Show
        Joe Schaefer added a comment - We have a CLA from Andrew Lutomirski, and I've spoken with Ben Matasar about resubmitting. No word on the others.
        Hide
        Joe Schaefer added a comment -

        Kevin Ko's ICLA is on file now. Andrew Lutomirski promises
        to send one in next week.

        Show
        Joe Schaefer added a comment - Kevin Ko's ICLA is on file now. Andrew Lutomirski promises to send one in next week.
        Joe Schaefer made changes -
        Resolution Fixed [ 1 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Hide
        Joe Schaefer added a comment -

        Need a CCLA from imeem.com for the contributions of

        Todd Berman
        Craig Kimerer
        Will Palmeri

        and and ICLA for the contributions of

        Patrick Collison
        Simon Forman
        Kevin Ko
        Andrew Lutomirski
        Ben Matasar
        William Morgan

        before mass-changing the license to AL-2.0. In the event
        we do not receive these items in a timely fashion, the fact
        that Thrift was open source can be used in our favor to
        treat those contributions as 3rd party works licensed under
        the Thrift license, which is sublicensable to AL-2.0. See

        http://www.softwarefreedom.org/resources/2007/gpl-non-gpl-collaboration.html

        for instructions on how this works in the GPL case, substituting
        AL-2.0 for the GPL as appropriate.

        Show
        Joe Schaefer added a comment - Need a CCLA from imeem.com for the contributions of Todd Berman Craig Kimerer Will Palmeri and and ICLA for the contributions of Patrick Collison Simon Forman Kevin Ko Andrew Lutomirski Ben Matasar William Morgan before mass-changing the license to AL-2.0. In the event we do not receive these items in a timely fashion, the fact that Thrift was open source can be used in our favor to treat those contributions as 3rd party works licensed under the Thrift license, which is sublicensable to AL-2.0. See http://www.softwarefreedom.org/resources/2007/gpl-non-gpl-collaboration.html for instructions on how this works in the GPL case, substituting AL-2.0 for the GPL as appropriate.
        Joe Schaefer made changes -
        Attachment license-and-notice.diff [ 12416387 ]
        Hide
        Joe Schaefer added a comment -

        All licenses on the distributed software need to appear in the LICENSE file.

        Show
        Joe Schaefer added a comment - All licenses on the distributed software need to appear in the LICENSE file.
        Bryan Duxbury made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Hide
        Bryan Duxbury added a comment -

        I just committed Jeremie's last patch. Thanks to everyone who contributed to this monster of an issue.

        Show
        Bryan Duxbury added a comment - I just committed Jeremie's last patch. Thanks to everyone who contributed to this monster of an issue.
        Jérémie BORDIER made changes -
        Attachment THRIFT-387_add_ASF_header_to_docs.patch [ 12404906 ]
        Hide
        Jérémie BORDIER added a comment -

        Add ASF header to all the documentation

        Show
        Jérémie BORDIER added a comment - Add ASF header to all the documentation
        Hide
        David Reiss added a comment -

        See my last comment.

        Show
        David Reiss added a comment - See my last comment.
        Hide
        Bryan Duxbury added a comment -

        Are there still more components to this issue, or is it done?

        Show
        Bryan Duxbury added a comment - Are there still more components to this issue, or is it done?
        Hide
        Kevin Clark added a comment -

        It's just adding headers to code. If things haven't blown up yet let's do this Tweaking headers and adding one offs is easy if something has somehow been missed.

        Show
        Kevin Clark added a comment - It's just adding headers to code. If things haven't blown up yet let's do this Tweaking headers and adding one offs is easy if something has somehow been missed.
        Hide
        Jérémie BORDIER added a comment -

        Thanks for this perfect set of patches David. Looks perfect, let's get this commited !

        Show
        Jérémie BORDIER added a comment - Thanks for this perfect set of patches David. Looks perfect, let's get this commited !
        Hide
        David Reiss added a comment -

        Added a bunch more patches. After these are applied, the remaining files with no license info are

        compiler/cpp/README
        CONTRIBUTORS
        doc/thrift.bnf
        doc/thrift.tex
        lib/cpp/README
        lib/csharp/src/Thrift.csproj
        lib/csharp/src/Thrift.sln
        lib/csharp/ThriftMSBuildTask/ThriftMSBuildTask.csproj
        lib/erl/README
        lib/erl/src/thrift.app.src
        lib/erl/src/thrift.appup.src
        lib/erl/vsn.mk
        lib/hs/README
        lib/hs/TODO
        lib/java/README
        lib/java/test/TestClient
        lib/java/test/TestNonblockingServer
        lib/java/test/TestServer
        lib/ocaml/README
        lib/ocaml/TODO
        lib/perl/README
        lib/php/README
        lib/php/README.apache
        lib/py/README
        lib/rb/CHANGELOG
        lib/rb/Manifest
        lib/rb/README
        lib/st/README
        NEWS
        README
        test/csharp/ThriftTest/ThriftTest.csproj
        tutorial/java/JavaClient
        tutorial/java/JavaServer
        tutorial/README
        contrib/fb303/README
        
        Show
        David Reiss added a comment - Added a bunch more patches. After these are applied, the remaining files with no license info are compiler/cpp/README CONTRIBUTORS doc/thrift.bnf doc/thrift.tex lib/cpp/README lib/csharp/src/Thrift.csproj lib/csharp/src/Thrift.sln lib/csharp/ThriftMSBuildTask/ThriftMSBuildTask.csproj lib/erl/README lib/erl/src/thrift.app.src lib/erl/src/thrift.appup.src lib/erl/vsn.mk lib/hs/README lib/hs/TODO lib/java/README lib/java/test/TestClient lib/java/test/TestNonblockingServer lib/java/test/TestServer lib/ocaml/README lib/ocaml/TODO lib/perl/README lib/php/README lib/php/README.apache lib/py/README lib/rb/CHANGELOG lib/rb/Manifest lib/rb/README lib/st/README NEWS README test/csharp/ThriftTest/ThriftTest.csproj tutorial/java/JavaClient tutorial/java/JavaServer tutorial/README contrib/fb303/README
        Hide
        Bryan Duxbury added a comment -

        I applied the patch and ran the java and ruby tests, and things look good. I say apply it!

        Show
        Bryan Duxbury added a comment - I applied the patch and ran the java and ruby tests, and things look good. I say apply it!
        Hide
        Jérémie BORDIER added a comment -

        Thank's David, lgtm. +1

        Show
        Jérémie BORDIER added a comment - Thank's David, lgtm. +1
        Hide
        David Reiss added a comment -

        Here's a version with a bunch of tweaks. v3 deleted some valid code from some Python files, handled a few of the csharp files weirdly, removed some @package declarations from some php files, added a header to setup.rb, etc.

        Show
        David Reiss added a comment - Here's a version with a bunch of tweaks. v3 deleted some valid code from some Python files, handled a few of the csharp files weirdly, removed some @package declarations from some php files, added a header to setup.rb, etc.
        David Reiss made changes -
        Hide
        Bryan Duxbury added a comment -

        What are we waiting on with this issue? I'd love to get this committed. Even if it's not 100% there, this thing is so monstrous, more than one commit would seem ok to me.

        Show
        Bryan Duxbury added a comment - What are we waiting on with this issue? I'd love to get this committed. Even if it's not 100% there, this thing is so monstrous, more than one commit would seem ok to me.
        Jérémie BORDIER made changes -
        Attachment THRIFT-387-asf-license.v3.patch [ 12403755 ]
        Hide
        Jérémie BORDIER added a comment -

        Reverted some files that are under specific licenses
        Added headers to thrift files and some forgotten shell scripts
        Removed old licenses here and there and removed all authors

        Show
        Jérémie BORDIER added a comment - Reverted some files that are under specific licenses Added headers to thrift files and some forgotten shell scripts Removed old licenses here and there and removed all authors
        Jérémie BORDIER made changes -
        Attachment THRIFT-387-asf-license.v2.patch [ 12403749 ]
        Hide
        Jérémie BORDIER added a comment -

        Fix executable scripts (license goes after shebang !)

        Show
        Jérémie BORDIER added a comment - Fix executable scripts (license goes after shebang !)
        Jérémie BORDIER made changes -
        Assignee Jérémie BORDIER [ ahfeel ]
        Jérémie BORDIER made changes -
        Field Original Value New Value
        Attachment THRIFT-387-asf-license.patch [ 12403743 ]
        Hide
        Jérémie BORDIER added a comment -

        Add ASF license everywhere needed, remove old licenses and remove useless COPYING files.

        Show
        Jérémie BORDIER added a comment - Add ASF license everywhere needed, remove old licenses and remove useless COPYING files.
        Hide
        Bryan Duxbury added a comment -

        I'm pretty sure the header needs to go on all the code. I would probably exclude the generated stuff, but basically everything else.

        Also, FYI, I intended this issue to cover all the libraries, not just ruby.

        Show
        Bryan Duxbury added a comment - I'm pretty sure the header needs to go on all the code. I would probably exclude the generated stuff, but basically everything else. Also, FYI, I intended this issue to cover all the libraries, not just ruby.
        Hide
        Kevin Clark added a comment -

        I just added the header to everything in rb/lib and rb/ext. Do we need to do it for the specs as well?

        Show
        Kevin Clark added a comment - I just added the header to everything in rb/lib and rb/ext. Do we need to do it for the specs as well?
        Bryan Duxbury created issue -

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Bryan Duxbury
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development