[THRIFT-3831] build of test/cpp/src/TestClient.cpp fails with newer gcc on platforms with unsigned char due to narrowing conversions

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.10.0
• Component/s: C++ - Library
• Patch Info: Patch Available
• Flags: Patch
• Assignee: Cody Schafer
• Reporter: Cody Schafer
• Created: 17/May/16 15:44
• Updated: 11/Oct/16 01:12
• Resolved: 01/Oct/16 15:00

Description

Specifically, we get a bunch of errors like:

test/cpp/src/TestClient.cpp:404:15: error: narrowing conversion of '-1' from 'int' to 'char' inside { } [-Wnarrowing]

gcc faq talks about this: https://gcc.gnu.org/wiki/FAQ#Wnarrowing

I've only seen this in gcc-6, but the faq seems to indicate it could occur in gcc-5 as well.

Issue Links

• links to: GitHub Pull Request #1085